Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add device integration page #1248

Merged
merged 9 commits into from
Oct 19, 2023
Merged

Conversation

Yndira-E
Copy link
Contributor

Description

Created the /certify-hardware/ page

Related Issue(s)

closes #1118

Checklist

  • I have read the contribution guidelines
  • I have considered the performance impact of these changes
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated

@Yndira-E Yndira-E linked an issue Oct 16, 2023 that may be closed by this pull request
@github-actions
Copy link
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 14.2%, saving 4.60 KB.

Filename Before After Improvement Visual comparison
src/images/pictograms/certified.png 32.37 KB 27.77 KB -14.2% View diff

619 images did not require optimisation.

@Yndira-E
Copy link
Contributor Author

@iskerrett @MarianRaphael should I add a link to this page under the product menu? or does it belong somewhere else?

@iskerrett
Copy link
Contributor

@iskerrett @MarianRaphael should I add a link to this page under the product menu? or does it belong somewhere else?

I would like to it from the Hardware Partner section on the https://flowfuse.com/partners/ page. Maybe add a button called 'Device Integration Details'

@Yndira-E
Copy link
Contributor Author

@iskerrett I just added the button, I used "CERTIFY YOUR HARDWARE" to make it similar to the title they will find in the /certify-hardware/ page.

@Yndira-E
Copy link
Contributor Author

@iskerrett @MarianRaphael I just added the FlowFuse certified device logo.

Once we've replaced the placeholder text in the "certification" section, it will be fully ready for review.

These are the pages that have been updated:
https://deploy-preview-1248--flowforge-website.netlify.app/partners/
https://deploy-preview-1248--flowforge-website.netlify.app/partners/certify-hardware/

Copy link
Contributor

@MarianRaphael MarianRaphael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks excellent, I suggested a change for the placeholder text.

@Yndira-E Yndira-E marked this pull request as ready for review October 18, 2023 14:21
<ul class="flex flex-row justify-center w-full items-center">
<li class="pb-6 hover:transition-opacity hover:opacity-75 transition ease-in duration-300">
<a href="/book-demo/" class="inline-block ff-btn ff-btn--primary uppercase w-[218px] m-auto text-center">
<span>BOOK A MEETING</span>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Book a Meeting button goes to Zack calendar which I don't think is correct. @MarianRaphael will you be doing these meetings?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just replaced the link, in the future I might change it to be a pop-up

@iskerrett iskerrett merged commit e583b67 into main Oct 19, 2023
6 checks passed
@iskerrett iskerrett deleted the 1118-add-device-integration-page branch October 19, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Device Integration page
3 participants